Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varying celestial transforms 3 d #277

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Conversation

svensk-pojke
Copy link
Contributor

Adds 3D capability to VaryingCelestialTransform and VaryingCelestialTransformSlit. Submitting PR now to facilitate deployment of Cryonirsp pipeline on DKIST DC stacks. A later upgrade to this code will include additional unit tests for transforms to include round trip pixel-to-world --> world to pixel testing. In addition, I will consolidate the many different VaryingCelestialTransform classes into far fewer, and evaluate the possibility of generic N dimensional VaryingCelestialTransform and VaryingCelestialTransformSlit classes.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #277 (afc379e) into main (d082995) will decrease coverage by 0.64%.
The diff coverage is 87.14%.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   97.09%   96.45%   -0.64%     
==========================================
  Files          37       37              
  Lines        2273     2371      +98     
==========================================
+ Hits         2207     2287      +80     
- Misses         66       84      +18     
Impacted Files Coverage Δ
dkist/wcs/models.py 96.77% <86.76%> (-3.23%) ⬇️
dkist/io/asdf/converters/models.py 97.95% <100.00%> (ø)

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you pinky promise to come back and write more tests then it's good with me 😉.

Can you add changelog fragment saying that "experimental support" or similar has been added for 3D table models?

@Cadair Cadair merged commit 9db1054 into main Jul 21, 2023
19 of 21 checks passed
@Cadair Cadair deleted the varying_celestial_transforms_3D branch July 21, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants