Skip to content

Commit

Permalink
Remove more accidentally exposed methods (firebase#723)
Browse files Browse the repository at this point in the history
- Remove `FirebaseAuth.current_user_DEPRECATED`
- Add a universal rule to ignore any method ended with `LastResult_DEPRECATED`
  • Loading branch information
chkuang-g authored May 17, 2023
1 parent 36c3398 commit 2437d11
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/src/swig/app.i
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ static firebase::AppOptions* AppOptionsLoadFromJsonConfig(const char* config) {
%warnfilter(844);
// Ignore all methods ending in LastResult.
%rename("$ignore", regextarget=1) "LastResult$";
%rename("$ignore", regextarget=1) "LastResult_DEPRECATED$";

%rename(FirebaseApp) firebase::App;
%typemap(csclassmodifiers) firebase::App "public sealed class";
Expand Down
3 changes: 2 additions & 1 deletion auth/src/swig/auth.i
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,8 @@ static CppInstanceManager<Auth> g_auth_instances;
// * firebase::auth::UserInfoInterface::ProviderId

// Deprecated method that conflicts with the CurrentUser property.
%ignore firebase::auth::Auth::CurrentUser;
%ignore firebase::auth::Auth::current_user;
%ignore firebase::auth::Auth::current_user_DEPRECATED;
// Make basic getters use C# Properties instead.
%attributeval(firebase::auth::Auth, firebase::auth::User,
CurrentUserInternal, current_user);
Expand Down

0 comments on commit 2437d11

Please sign in to comment.