Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signer uniqueness checking #122

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: signer uniqueness checking #122

merged 1 commit into from
Oct 16, 2024

Conversation

scolear
Copy link
Contributor

@scolear scolear commented Oct 10, 2024

A new mapping which stores signer uniqueness for a given message hash. It ensures that the same signers can submit signatures for different messages (since the message fields are unique in btcTxId), but not for the same one.

Rayerleier
Rayerleier previously approved these changes Oct 11, 2024
Copy link

@Rayerleier Rayerleier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great optimization!Reduced the time complexity from O(n²) to O(1).

sosaucily
sosaucily previously approved these changes Oct 11, 2024
@scolear scolear dismissed stale reviews from sosaucily and Rayerleier via 52e8b3d October 15, 2024 08:53
@scolear scolear force-pushed the fix/signer-checking branch from a2806b8 to 52e8b3d Compare October 15, 2024 08:53
@scolear scolear merged commit f64c9a4 into dev Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants