Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature multiple attributes ghost commit from stash #1173

Merged
merged 20 commits into from
Sep 23, 2024

Conversation

lukasdreyer
Copy link
Collaborator

Describe your changes here:

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@holke
Copy link
Collaborator

holke commented Jul 22, 2024

Needs to be cleaned up.
There are still debug statements and comments that should be cleaned up.

@holke holke added next release For the next release priority: high Should be solved as soon as possible labels Jul 22, 2024
@holke holke self-assigned this Jul 22, 2024
@holke
Copy link
Collaborator

holke commented Jul 22, 2024

Closes #1114

@holke holke marked this pull request as ready for review July 23, 2024 07:52
@holke holke enabled auto-merge July 23, 2024 07:53
@holke holke removed their assignment Jul 23, 2024
@Davknapp Davknapp added the workload: medium Would take a week or less label Aug 12, 2024
test/t8_cmesh/t8_gtest_cmesh_partition.cxx Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_trees.h Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_trees.cxx Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_trees.cxx Outdated Show resolved Hide resolved
@jmark
Copy link
Collaborator

jmark commented Aug 12, 2024

@lukasdreyer Thank you for your work on this PR! Please see the review comments above. Also please resolve the merge conflict.

@jmark jmark assigned lukasdreyer and unassigned jmark Aug 12, 2024
@lukasdreyer lukasdreyer assigned jmark and unassigned lukasdreyer Sep 13, 2024
@holke holke merged commit e92f3bc into main Sep 23, 2024
22 checks passed
@holke holke deleted the feature-multiple_attributes_ghost_commit_from_stash branch September 23, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release For the next release priority: high Should be solved as soon as possible workload: medium Would take a week or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully enable cmesh ghost attributes when committing a partitioned cmesh from stash
4 participants