Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dimensionality of geoms #1215

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

sandro-elsweijer
Copy link
Collaborator

Describe your changes here:
After adding the geometry tree checking int cmesh commit the dimensionality of geometries becomes obsolete.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@sandro-elsweijer sandro-elsweijer added enhancement Enhances already existing code draft Enhance the visibility that this is a draft. Follow-up PR priority: low Should be solved eventually workload: low Would take half a day or less labels Aug 13, 2024
@sandro-elsweijer sandro-elsweijer changed the base branch from main to enhancement-geometry_checking August 13, 2024 14:52
Base automatically changed from enhancement-geometry_checking to main September 6, 2024 12:35
@sandro-elsweijer sandro-elsweijer removed the draft Enhance the visibility that this is a draft. label Sep 6, 2024
@sandro-elsweijer sandro-elsweijer marked this pull request as ready for review September 6, 2024 14:13
@jmark jmark enabled auto-merge October 8, 2024 14:18
@jmark jmark merged commit f61d44d into main Oct 8, 2024
27 checks passed
@jmark jmark deleted the enhancement-remove_dimensionality_of_geoms branch October 8, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code Follow-up PR priority: low Should be solved eventually workload: low Would take half a day or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants