Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 49 - tetgen reader #564

Merged
merged 14 commits into from
Jan 30, 2024
Merged

Fix issue 49 - tetgen reader #564

merged 14 commits into from
Jan 30, 2024

Conversation

ililikakis
Copy link
Contributor

@ililikakis ililikakis commented May 23, 2023

Describe your changes here:

The reason for the failed reading of the tetgen files is that it was assumed that the neighboring elements in the .neigh file are ordered according to the facenumbering of t8code. However, this is not the case.
The adjacent faces between two neighboring tetrahedra must therefore be calculated separately.

The method must be tested manually. Please do for triangles as well as for tetrahedra.
TET:

  • get tetgen
  • get example files
  • generating the mesh with .\tetgen -pn cube.poly
  • run ./example/IO/cmesh/tetgen/t8_read_tetgen -p0 -f<path to cube.1 file>

TRI:

  • get triangle
  • generating the mesh with .\triangle -pn A.poly or use other example
  • run ./example/IO/cmesh/triangle/t8_read_triangle -p0 -f<path to A.1 file>

Do NOT use partitioning, this is another issue.

Closes #49

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp self-requested a review June 30, 2023 13:42
@jmark jmark merged commit de68bfe into main Jan 30, 2024
8 checks passed
@jmark jmark deleted the fix-tetgen_reader branch January 30, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Tetgen input
3 participants