Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature remove elements #581

Merged
merged 286 commits into from
Jun 27, 2023
Merged

Conversation

ililikakis
Copy link
Contributor

Describe your changes here:
Implementation of my thesis Algorithms for tree-based adaptive meshes with incomplete trees

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

ililikakis and others added 30 commits April 6, 2022 10:00
Co-authored-by: Davknapp <david.knapp@dlr.de>
Co-authored-by: Davknapp <david.knapp@dlr.de>
Co-authored-by: Davknapp <david.knapp@dlr.de>
Co-authored-by: Davknapp <david.knapp@dlr.de>
Co-authored-by: Davknapp <david.knapp@dlr.de>
Co-authored-by: Davknapp <david.knapp@dlr.de>
@ililikakis ililikakis assigned ililikakis and unassigned Davknapp Jun 21, 2023
@ililikakis ililikakis assigned Davknapp and unassigned ililikakis Jun 22, 2023
@Davknapp Davknapp marked this pull request as ready for review June 27, 2023 06:59
example/remove/t8_example_empty_trees.cxx Outdated Show resolved Hide resolved
example/remove/t8_example_empty_trees.cxx Outdated Show resolved Hide resolved
example/remove/t8_example_empty_trees.cxx Outdated Show resolved Hide resolved
example/remove/t8_example_empty_trees.cxx Show resolved Hide resolved
example/remove/t8_example_empty_trees.cxx Show resolved Hide resolved
test/t8_forest_incomplete/t8_gtest_empty_global_tree.cxx Outdated Show resolved Hide resolved
test/t8_forest_incomplete/t8_gtest_empty_global_tree.cxx Outdated Show resolved Hide resolved
test/t8_forest_incomplete/t8_gtest_empty_global_tree.cxx Outdated Show resolved Hide resolved
test/t8_forest_incomplete/t8_gtest_empty_local_tree.cxx Outdated Show resolved Hide resolved
@Davknapp Davknapp assigned ililikakis and unassigned Davknapp Jun 27, 2023
@ililikakis ililikakis assigned Davknapp and unassigned ililikakis Jun 27, 2023
@Davknapp
Copy link
Collaborator

Great Addition, thank you for your work and all the changes due to my review!
The honor of pressing the merge-button is yours ;)

@ililikakis ililikakis merged commit 85e3fef into DLR-AMR:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants