Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature curved triangles #590

Merged
merged 68 commits into from
Jul 27, 2023

Conversation

jfussbro
Copy link
Contributor

@jfussbro jfussbro commented Jun 27, 2023

Describe your changes here:

Enables curved triangular elements (simple geometry example exists now) and fixes problem with disorted elements on closed surfaces.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

Knapp and others added 30 commits June 26, 2023 11:12
Please recheck if I added the right path
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
… t8_geom_evaluate_occ_triangle

fixed wrong brep output in t8_example_geometries.cxx. Implemented intersection in t8_geom_evaluate_occ_triangle

further implementations in t8_geom_evaluate_occ_trinangle
…ctionality

some debugging

first working version of t8_geom_evaluate_occ_triangle
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
src/t8_geometry/t8_geometry_helpers.c Outdated Show resolved Hide resolved
src/t8_geometry/t8_geometry_helpers.c Outdated Show resolved Hide resolved
src/t8_geometry/t8_geometry_helpers.c Outdated Show resolved Hide resolved
src/t8_geometry/t8_geometry_helpers.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_readmshfile.cxx Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_readmshfile.cxx Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_readmshfile.cxx Outdated Show resolved Hide resolved
src/t8_geometry/t8_geometry_helpers.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

src/t8_cmesh/t8_cmesh_readmshfile.cxx Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_readmshfile.cxx Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_readmshfile.cxx Outdated Show resolved Hide resolved
@sandro-elsweijer sandro-elsweijer merged commit 94c6faa into DLR-AMR:main Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants