-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature curved triangles #590
Merged
sandro-elsweijer
merged 68 commits into
DLR-AMR:main
from
jfussbro:feature_curved_triangles
Jul 27, 2023
Merged
Feature curved triangles #590
sandro-elsweijer
merged 68 commits into
DLR-AMR:main
from
jfussbro:feature_curved_triangles
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please recheck if I added the right path
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
… t8_geom_evaluate_occ_triangle fixed wrong brep output in t8_example_geometries.cxx. Implemented intersection in t8_geom_evaluate_occ_triangle further implementations in t8_geom_evaluate_occ_trinangle
…ctionality some debugging first working version of t8_geom_evaluate_occ_triangle
…ns in t8_geometry_helpers
jfussbro
force-pushed
the
feature_curved_triangles
branch
from
July 17, 2023 15:16
9dcd8d6
to
6987c71
Compare
sandro-elsweijer
requested changes
Jul 24, 2023
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.cxx
Outdated
Show resolved
Hide resolved
jfussbro
force-pushed
the
feature_curved_triangles
branch
from
July 25, 2023 08:44
94f529d
to
831b05e
Compare
sandro-elsweijer
requested changes
Jul 25, 2023
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.hxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.hxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.hxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.hxx
Outdated
Show resolved
Hide resolved
…nd v parameter in case of a surface
…meter and takes an additional parameter argument
sandro-elsweijer
requested changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
src/t8_geometry/t8_geometry_implementations/t8_geometry_occ.cxx
Outdated
Show resolved
Hide resolved
sandro-elsweijer
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Enables curved triangular elements (simple geometry example exists now) and fixes problem with disorted elements on closed surfaces.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)