-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature puma patches [8/x] Batch processing of tree ref_coords [3/x] Curved geometries #667
Conversation
…feature-puma_patches_batch_processing_geometry3
518dbc0
to
7fd35a6
Compare
…eature-puma_patches_batch_processing_geometry3
…s_batch_processing_geometry3
…batch_processing_geometry3
src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_cad.cxx
Outdated
Show resolved
Hide resolved
…batch_processing_geometry3
…batch_processing_geometry3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfussbro @sandro-elsweijer Please update to the latest main
. Especially the p4est
and libsc
submodules have changed.
Furthmore, I get two failing tests when compiling and testing in debug mode (--enable-debug
). See my log file.
test-suite.log.txt
Please fix this. Besides that LGTM!
Lgtm :) |
…batch_processing_geometry3
Thanks for taking a look at it! All checks pass locally and in the CI on my side. The examples work fine as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfussbro Thank you very much for your work!
I tested your PR locally on my machine. I noticed that this PR still significantly diverges from the current main
. Please merge with the current main
and resolve the merge conflicts. Tip: Make sure that your local main
is up-to-date with the one in the repo.
Describe your changes here:
Closes #446
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)