Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature puma patches [8/x] Batch processing of tree ref_coords [3/x] Curved geometries #667

Merged
merged 62 commits into from
Apr 29, 2024

Conversation

sandro-elsweijer
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer commented Aug 7, 2023

Describe your changes here:

Closes #446

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@sandro-elsweijer sandro-elsweijer self-assigned this Aug 7, 2023
@sandro-elsweijer sandro-elsweijer added enhancement Enhances already existing code Follow-up PR labels Aug 7, 2023
@sandro-elsweijer sandro-elsweijer changed the base branch from main to feature-puma_patches_batch_processing_geometry2 August 7, 2023 13:40
@sandro-elsweijer sandro-elsweijer linked an issue Aug 9, 2023 that may be closed by this pull request
…feature-puma_patches_batch_processing_geometry3
@sandro-elsweijer sandro-elsweijer force-pushed the feature-puma_patches_batch_processing_geometry3 branch from 518dbc0 to 7fd35a6 Compare August 18, 2023 09:29
src/t8_geometry/t8_geometry_helpers.c Outdated Show resolved Hide resolved
Base automatically changed from feature-puma_patches_batch_processing_geometry2 to main September 14, 2023 10:30
@jmark jmark self-assigned this Sep 18, 2023
@jmark jmark added the draft Enhance the visibility that this is a draft. label Sep 20, 2023
@jmark jmark removed their assignment Sep 20, 2023
Copy link
Collaborator

@jmark jmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfussbro @sandro-elsweijer Please update to the latest main. Especially the p4est and libsc submodules have changed.

Furthmore, I get two failing tests when compiling and testing in debug mode (--enable-debug). See my log file.
test-suite.log.txt

Please fix this. Besides that LGTM!

@jmark jmark assigned jfussbro and unassigned sandro-elsweijer Apr 22, 2024
@jmark jmark removed the draft Enhance the visibility that this is a draft. label Apr 22, 2024
@jmark jmark assigned sandro-elsweijer and unassigned jmark Apr 22, 2024
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
example/geometry/t8_example_geometries.cxx Outdated Show resolved Hide resolved
test/t8_schemes/t8_gtest_element_ref_coords.cxx Outdated Show resolved Hide resolved
@sandro-elsweijer
Copy link
Collaborator Author

Lgtm :)

@sandro-elsweijer sandro-elsweijer removed their assignment Apr 25, 2024
@jfussbro
Copy link
Contributor

@jfussbro @sandro-elsweijer Please update to the latest main. Especially the p4est and libsc submodules have changed.

Furthmore, I get two failing tests when compiling and testing in debug mode (--enable-debug). See my log file. test-suite.log.txt

Please fix this. Besides that LGTM!

Thanks for taking a look at it! All checks pass locally and in the CI on my side. The examples work fine as well.

@jfussbro jfussbro assigned jmark and sandro-elsweijer and unassigned jfussbro Apr 26, 2024
jmark
jmark previously requested changes Apr 29, 2024
Copy link
Collaborator

@jmark jmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfussbro Thank you very much for your work!

I tested your PR locally on my machine. I noticed that this PR still significantly diverges from the current main. Please merge with the current main and resolve the merge conflicts. Tip: Make sure that your local main is up-to-date with the one in the repo.

@jmark jmark dismissed their stale review April 29, 2024 09:49

Forgot to pull. Never mind.

@jmark jmark merged commit 11de3be into main Apr 29, 2024
8 checks passed
@jmark jmark deleted the feature-puma_patches_batch_processing_geometry3 branch April 29, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code Follow-up PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt curved geometry evaluation to p4est edge numeration
3 participants