Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved quadrangulated disk mesh cmesh example [6/n] #796

Merged
merged 12 commits into from
Feb 27, 2024

Conversation

jmark
Copy link
Collaborator

@jmark jmark commented Oct 13, 2023

Describe your changes here:

This is a follow-up to #792.

This PR improves the squared disk cmesh example by rearranging the initial cmesh elements. This should lead
to a better distribution of characteristic element sizes of same refinement level.
grafik

Added also a 3D version: cubed sphere
grafik
grafik

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@jmark jmark added enhancement Enhances already existing code examples Edits in our examples labels Oct 13, 2023
@jmark jmark changed the base branch from main to addition-cmesh-example-triangulated-spherical-surface October 13, 2023 12:18
@jmark jmark changed the base branch from addition-cmesh-example-triangulated-spherical-surface to addition-cmesh-example-triangulated-spherical-surface-icas October 13, 2023 12:18
@jmark jmark changed the title Improved squared disk mesh cmesh example [6/n] Improved quadrangulated disk mesh cmesh example [6/n] Jan 30, 2024
@jmark jmark marked this pull request as ready for review January 30, 2024 14:42
Base automatically changed from addition-cmesh-example-triangulated-spherical-surface-icas to main February 8, 2024 15:15
@holke holke assigned holke and lukasdreyer and unassigned holke Feb 26, 2024
@lukasdreyer lukasdreyer assigned jmark and unassigned lukasdreyer Feb 26, 2024
@jmark jmark assigned lukasdreyer and unassigned jmark Feb 27, 2024
@lukasdreyer lukasdreyer merged commit 7f47e70 into main Feb 27, 2024
8 checks passed
@lukasdreyer lukasdreyer deleted the play-with-squared-disk-mesh branch February 27, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code examples Edits in our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants