Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ghost for forests with holes #828

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Test ghost for forests with holes #828

merged 7 commits into from
Jan 8, 2024

Conversation

lukasdreyer
Copy link
Collaborator

Describe your changes here:
Ghost currently does not work on forests with deleted elements. This test is an example of a configuration that fails.
See #825.
It does not fail when the second adapt call is done without ghosts

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@lukasdreyer
Copy link
Collaborator Author

In the spellcheck and indent commit, I accidentally committed the version, that does not compute ghosts and therefore does not throw an error

Copy link
Collaborator

@holke holke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the new guidelines for test driven development: https://github.com/DLR-AMR/t8code/wiki/Test-driven-development

test/t8_forest/t8_gtest_ghost_delete.cxx Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Show resolved Hide resolved
test/t8_forest/t8_gtest_ghost_delete.cxx Show resolved Hide resolved
@Davknapp Davknapp assigned Davknapp and unassigned Davknapp Nov 16, 2023
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, if @holke is fine with it, we can merge it.

@holke
Copy link
Collaborator

holke commented Nov 24, 2023

Approved.
@lukasdreyer is there a reason why its still in draft mode or can we take it out of draft and merge?

@holke holke assigned lukasdreyer and unassigned holke and Davknapp Nov 24, 2023
@lukasdreyer lukasdreyer marked this pull request as ready for review December 11, 2023 09:06
@lukasdreyer
Copy link
Collaborator Author

Approved. @lukasdreyer is there a reason why its still in draft mode or can we take it out of draft and merge?

No reason, I just forgot about it.

@lukasdreyer lukasdreyer assigned holke and Davknapp and unassigned lukasdreyer Dec 11, 2023
@holke holke enabled auto-merge January 8, 2024 13:25
@holke holke merged commit 18ea413 into main Jan 8, 2024
8 checks passed
@holke holke deleted the test_cmesh_holes_ghost branch January 8, 2024 13:26
@lukasdreyer lukasdreyer mentioned this pull request Jan 9, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants