Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file #840

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Remove file #840

merged 3 commits into from
Jan 16, 2024

Conversation

Davknapp
Copy link
Collaborator

This is a very basic example, therefore I removed it.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp added examples Edits in our examples cleanup Cleans the code labels Nov 14, 2023
@chiaraMaHe chiaraMaHe self-assigned this Nov 17, 2023
@chiaraMaHe
Copy link
Collaborator

The file is also mentioned in ./gitignore. Is this file generated automatically? Otherwise it has to be removed

@chiaraMaHe chiaraMaHe assigned Davknapp and unassigned chiaraMaHe Nov 24, 2023
@Davknapp
Copy link
Collaborator Author

The file is also mentioned in ./gitignore. Is this file generated automatically? Otherwise it has to be removed

Good catch, thank you ;)

@Davknapp Davknapp assigned chiaraMaHe and unassigned Davknapp Nov 24, 2023
@chiaraMaHe chiaraMaHe merged commit b55fc6b into main Jan 16, 2024
8 checks passed
@chiaraMaHe chiaraMaHe deleted the example_remove_refine branch January 16, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleans the code examples Edits in our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants