Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyramid face corner #863

Merged
merged 16 commits into from
Feb 7, 2024
Merged

Fix pyramid face corner #863

merged 16 commits into from
Feb 7, 2024

Conversation

lukasdreyer
Copy link
Collaborator

@lukasdreyer lukasdreyer commented Nov 21, 2023

Describe your changes here:
Should adress #862. Need discussion with @Davknapp regarding current standards for vertex and face enumeration of pyramids.

This fixes t8_dpyramid_face_corner to fit to t8_dpyramid_face_neighbour and t8_dpyramid_vertex_reference_coords.
Attention: The relation of faces to vertices differs for the two pyramid types!

In the future, this relation should be the same for every element shape.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@lukasdreyer
Copy link
Collaborator Author

The newly added test fails in parallel because of offsets, but it passes on this branch in serial, and fails in serial on main.

@lukasdreyer lukasdreyer marked this pull request as ready for review November 22, 2023 10:35
test/t8_forest/t8_gtest_forest_face_normal.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_forest_face_normal.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_forest_face_normal.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_forest_face_normal.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_forest_face_normal.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_forest_face_normal.cxx Outdated Show resolved Hide resolved
@Davknapp Davknapp assigned lukasdreyer and unassigned Davknapp Nov 22, 2023
@lukasdreyer lukasdreyer assigned Davknapp and unassigned lukasdreyer Nov 22, 2023
@Davknapp Davknapp assigned lukasdreyer and unassigned Davknapp Nov 23, 2023
@lukasdreyer lukasdreyer assigned Davknapp and unassigned lukasdreyer Jan 3, 2024
@holke holke enabled auto-merge February 7, 2024 11:53
@holke holke removed their assignment Feb 7, 2024
@lukasdreyer
Copy link
Collaborator Author

Merging main and making two errors in the _ext function that I introduced let me think about whether we really need the _ext version when switching to t8code 2.0, or if we can replace the standard version of that function

@lukasdreyer lukasdreyer merged commit fb4728a into main Feb 7, 2024
8 checks passed
@lukasdreyer lukasdreyer deleted the fix_pyramid-face-corner branch February 7, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants