Feature test cmesh set partition offset #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to a comment in the code, t8_cmesh_set_partition_offsets does not work with underived cmeshes. We started with test cases to check this comment.
…set_partition_offsets
- value ranges over classes and tree count - check that the cmesh is committed - check that the cmesh is partitioned according to the offset
…e-test_cmesh_set_partition_offset
14 tasks
holke
commented
Nov 29, 2023
Davknapp
requested changes
Nov 30, 2023
There was a problem hiding this comment.
In both Tests you can also move the cmesh, the shmem_array and the initialization of the communicator in the SetUp-function of the class. The counterpart can be moved into the TearDown-function. That way the test shows exactly what is tested.
In the Test cmesh_set_partition_offsets_nocommit nothing is tested, but you say, that we need a "valid partition". Is this something we can test for?
Davknapp
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Note: Merge #868 first.
Add two test cases for the t8_cmesh_set_partition_offsets function with an underived cmesh.
We build a cmesh from scratch and call t8_cmesh_set_partition_offsets.
in the first test, we destroy the cmesh immediately, in the second we commit the cmesh and check whether it was partitioned correctly.
The tests iterate over the eclasses and a range of tree counts.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.Licence
doc/(or already has one)