Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug 873 #880

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Fix Bug 873 #880

merged 3 commits into from
Dec 11, 2023

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Dec 8, 2023

Cause of the error:
During partitioning of the cmesh vertex-data of the tree can be moved around. If the active tree of the geometry is the same as befor partitioning the vertex-data has been moved without notifying the geometry.
Solution:
The active tree of the geometry-handler is set to a negative value that is out of bounds of the possible ltreeids. Therefore the active tree is set again as soon as we want to load tree data and the tree-data is actually loaded.

Thanks to @lukasdreyer for helping with the bug-hunt.

Closes #873

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

tree-data (such as vertices) might have been moved and need to be loaded again
@Davknapp Davknapp added the Bug For a bug in the Code label Dec 8, 2023
Move the function call inside of the profiling
@Davknapp Davknapp requested a review from holke December 11, 2023 14:51
src/t8_geometry/t8_geometry.h Show resolved Hide resolved
@holke holke enabled auto-merge December 11, 2023 15:32
@holke holke merged commit 612b4bc into main Dec 11, 2023
8 checks passed
@holke holke deleted the fix-bug_873 branch December 11, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For a bug in the Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in Coarsen and Refine
2 participants