Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation CI and indentation #885

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

lukasdreyer
Copy link
Collaborator

@lukasdreyer lukasdreyer commented Jan 3, 2024

Describe your changes here:
The indentation check CI Pipeline was not working correctly.
Redirecting stderr to stdout after calling the indentation script check overwrites the exit code, therefore always showing that the indentation check worked.

This PR fixes that problem and the indentation errors that were introduced in the meantime.
See the follwing CI Job for an example of a failing run:
https://github.com/DLR-AMR/t8code/actions/runs/7407043980/job/20152521092

Please also delete branch indent_fail_check when merging.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@lukasdreyer lukasdreyer changed the title Fix indentation Fix indentation CI and indentation Jan 4, 2024
@lukasdreyer
Copy link
Collaborator Author

To the merger: Please also delete branch indent_fail_check

@lukasdreyer lukasdreyer marked this pull request as ready for review January 4, 2024 08:24
@sandro-elsweijer sandro-elsweijer self-assigned this Jan 4, 2024
@sandro-elsweijer sandro-elsweijer merged commit cf33e52 into main Jan 4, 2024
8 checks passed
@sandro-elsweijer sandro-elsweijer deleted the fix_indentation branch January 4, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants