-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature element pack #890
Feature element pack #890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a first look at it and I like this feature already.
src/t8_schemes/t8_default/t8_default_hex/t8_default_hex_cxx.cxx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i only checked the implementation not the test.
Thanks for the effort - this will greatly improve inclusion of new schemes in the future and makes the existing code base mor type safe.
src/t8_schemes/t8_default/t8_default_hex/t8_default_hex_cxx.cxx
Outdated
Show resolved
Hide resolved
src/t8_schemes/t8_default/t8_default_hex/t8_default_hex_cxx.hxx
Outdated
Show resolved
Hide resolved
Co-authored-by: David Knapp <david.knapp@dlr.de>
… feature-element_pack
Still a draft, because cburstedde/libsc#166 needs to be merged first, and the correct branch needs to be adjusted |
src/t8_schemes/t8_default/t8_default_hex/t8_default_hex_cxx.cxx
Outdated
Show resolved
Hide resolved
src/t8_schemes/t8_default/t8_default_prism/t8_default_prism_cxx.cxx
Outdated
Show resolved
Hide resolved
2f0ebf2
to
9836591
Compare
8b0b295
to
f6a6718
Compare
6d680ff
to
687a66f
Compare
src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex_cxx.cxx
Outdated
Show resolved
Hide resolved
src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex_cxx.cxx
Outdated
Show resolved
Hide resolved
src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex_cxx.hxx
Outdated
Show resolved
Hide resolved
src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex_cxx.hxx
Outdated
Show resolved
Hide resolved
src/t8_schemes/t8_default/t8_default_vertex/t8_default_vertex_cxx.hxx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this nice feature!
Describe your changes here:
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)