Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature element pack #890

Merged
merged 34 commits into from
Mar 12, 2024
Merged

Feature element pack #890

merged 34 commits into from
Mar 12, 2024

Conversation

lukasdreyer
Copy link
Collaborator

@lukasdreyer lukasdreyer commented Jan 9, 2024

Describe your changes here:

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a first look at it and I like this feature already.

test/t8_schemes/t8_gtest_pack_unpack.cxx Outdated Show resolved Hide resolved
test/t8_schemes/t8_gtest_pack_unpack.cxx Outdated Show resolved Hide resolved
src/t8_element_cxx.hxx Outdated Show resolved Hide resolved
src/t8_element_cxx.hxx Outdated Show resolved Hide resolved
src/t8_element_cxx.hxx Outdated Show resolved Hide resolved
src/t8_element_cxx.hxx Outdated Show resolved Hide resolved
Copy link
Collaborator

@holke holke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only checked the implementation not the test.

Thanks for the effort - this will greatly improve inclusion of new schemes in the future and makes the existing code base mor type safe.

.gitmodules Outdated Show resolved Hide resolved
src/t8_element_c_interface.h Outdated Show resolved Hide resolved
src/t8_element_cxx.hxx Outdated Show resolved Hide resolved
src/t8_element_cxx.hxx Outdated Show resolved Hide resolved
src/t8_schemes/t8_default/t8_default_tet/t8_dtet_bits.c Outdated Show resolved Hide resolved
@jmark jmark added the draft Enhance the visibility that this is a draft. label Jan 15, 2024
@lukasdreyer
Copy link
Collaborator Author

Still a draft, because cburstedde/libsc#166 needs to be merged first, and the correct branch needs to be adjusted

@lukasdreyer lukasdreyer marked this pull request as ready for review February 28, 2024 16:09
@lukasdreyer lukasdreyer removed the draft Enhance the visibility that this is a draft. label Feb 28, 2024
src/t8_element_c_interface.cxx Outdated Show resolved Hide resolved
src/t8_element_c_interface.cxx Outdated Show resolved Hide resolved
src/t8_element_c_interface.cxx Outdated Show resolved Hide resolved
src/t8_element_c_interface.h Outdated Show resolved Hide resolved
src/t8_element_c_interface.h Outdated Show resolved Hide resolved
@Davknapp Davknapp assigned lukasdreyer and unassigned Davknapp Mar 12, 2024
@lukasdreyer lukasdreyer assigned Davknapp and unassigned lukasdreyer Mar 12, 2024
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice feature!

@Davknapp Davknapp removed their assignment Mar 12, 2024
@holke holke enabled auto-merge March 12, 2024 12:02
@holke holke merged commit 699c6a5 into main Mar 12, 2024
8 checks passed
@holke holke deleted the feature-element_pack branch March 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants