Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: balance forest #925

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Tests: balance forest #925

merged 6 commits into from
Feb 28, 2024

Conversation

Niklas997
Copy link
Collaborator

Describe your changes here:
Added some tests regarding the balance functionality.

This covers a test for expected behaviour on a simple un-balanced forest as well as some tests of the boolean t8_forest_is_balanced function and a consistency test for an already balanced forest.

Some of the balance functionality was already called within the test t8_gtest_forest_commit which was not added to the testsuite beforehand.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@holke holke added the next release For the next release label Feb 5, 2024
test/Makefile.am Show resolved Hide resolved
test/t8_forest/t8_gtest_balance.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_balance.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_balance.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_balance.cxx Outdated Show resolved Hide resolved
test/t8_forest/t8_gtest_balance.cxx Show resolved Hide resolved
test/t8_forest/t8_gtest_balance.cxx Outdated Show resolved Hide resolved
@Niklas997 Niklas997 assigned jmark and unassigned Niklas997 Feb 26, 2024
@jmark jmark merged commit e325e8c into main Feb 28, 2024
8 checks passed
@jmark jmark deleted the test-t8_forest_balance branch February 28, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release For the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants