Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binary vtk option #928

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Remove binary vtk option #928

merged 6 commits into from
Feb 8, 2024

Conversation

holke
Copy link
Collaborator

@holke holke commented Feb 5, 2024

Describe your changes here:

The cmesh vtk had macros distinguishing between binary/compressed VTK output and ascii output.
Even though only the ascii version was implemented.

Since we do not plan on implementing the compressed output, and the setting was not even in the configure, we remove it completely.
This cleans up the code.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@holke holke force-pushed the feature-remove_binary_vtk_option branch from c411f84 to 2e99f8f Compare February 5, 2024 13:24
@holke holke added the next release For the next release label Feb 5, 2024
@holke holke enabled auto-merge February 7, 2024 09:57
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comment, then we should be good to go

src/t8_vtk.h Outdated Show resolved Hide resolved
@Davknapp Davknapp assigned holke and unassigned Davknapp Feb 8, 2024
Co-authored-by: David Knapp <david.knapp@dlr.de>
@holke holke assigned Davknapp and unassigned holke Feb 8, 2024
@holke holke merged commit 36ec0ef into main Feb 8, 2024
8 checks passed
@holke holke deleted the feature-remove_binary_vtk_option branch February 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release For the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants