Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test - Additional geometry tests #942

Merged
merged 15 commits into from
Mar 22, 2024
Merged

Test - Additional geometry tests #942

merged 15 commits into from
Mar 22, 2024

Conversation

jfussbro
Copy link
Contributor

…Contents

Describe your changes here:

The new tests test the t8_geometry_occ functions. Now there are tests for the linkage of linear and curved curves and surfaces for all 2d element types.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@jfussbro jfussbro added the tests label Feb 15, 2024
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a quick look at it and found an opportunity to use one of our custom assertions to compare two 3D-vectors.

@Davknapp Davknapp mentioned this pull request Feb 15, 2024
14 tasks
@holke holke added the next release For the next release label Feb 19, 2024
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also test every orientation of the trees

@sandro-elsweijer
Copy link
Collaborator

We should also test every orientation of the trees

Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment

@jfussbro jfussbro merged commit bdd8948 into main Mar 22, 2024
8 checks passed
@jfussbro jfussbro deleted the test_geometry_occ_functions branch March 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release For the next release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants