Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vtk reader test for MPI sizes other than 2. #951

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

jmark
Copy link
Collaborator

@jmark jmark commented Feb 20, 2024

Describe your changes here:

This PR fixes a silently failing test by crashing for mpisizes other than two. The test actually assumes two ranks by design.
Autotools ignores the crash while cmake marks this as a failed test. This is the error message when calling with one rank:

Abort(469312775) on node 0 (rank 0 in comm 0): Fatal error in internal_Bcast: Invalid root, error stack:
internal_Bcast(107): MPI_Bcast(buffer=0x7ffc3584882c, count=1, MPI_INT, 1, MPI_COMM_WORLD) failed
internal_Bcast(61).: Invalid root (value given was 1)

Proposed solution: Just skip it for mpisizes other than two. Note, two MPI ranks is the default within the Github CI. So this test is properly covered there.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@jmark jmark added Bug For a bug in the Code tests labels Feb 20, 2024
@jmark jmark changed the title Skip vtk reader test for mpisize other than 2. Skip vtk reader test for MPI sizes other than 2. Feb 20, 2024
@lukasdreyer lukasdreyer assigned lukasdreyer and jmark and unassigned lukasdreyer Feb 21, 2024
@jmark jmark assigned lukasdreyer and unassigned jmark Feb 21, 2024
@lukasdreyer lukasdreyer merged commit e5c5abc into main Feb 21, 2024
8 checks passed
@lukasdreyer lukasdreyer deleted the fix-failing-test-in-vtk-reader branch February 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For a bug in the Code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants