Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty cmeshes #965

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Added empty cmeshes #965

merged 4 commits into from
Mar 5, 2024

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Mar 1, 2024

Added empty cmeshes to new test-suite

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp added enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins tests Follow-up PR labels Mar 1, 2024
Base automatically changed from add-parametrized_cmesh_example to main March 1, 2024 13:51
Copy link
Contributor

@jfussbro jfussbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine :) I just added 2 small suggestions but i am not completely sure if they are necessary

Davknapp and others added 2 commits March 4, 2024 16:38
…h_new_empty.hxx

Co-authored-by: Jakob Fußbroich <71825121+jfussbro@users.noreply.github.com>
…h_new_empty.hxx

Co-authored-by: Jakob Fußbroich <71825121+jfussbro@users.noreply.github.com>
@Davknapp Davknapp merged commit fbc827b into main Mar 5, 2024
8 checks passed
@Davknapp Davknapp deleted the add-empty_cmesh_examples branch March 5, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code Follow-up PR shouldn't take long Can be resolved in under 30 mins tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants