Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DQN optimizer input to only include q_network parameters as input #1963

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

corentinlger
Copy link
Contributor

@corentinlger corentinlger commented Jul 5, 2024

Updated DQN optimizer input to only include q_network parameters as input (similarly to what is done in SAC)

I didn't modify the tests because it seems they were already checking the right thing before (what we discussed in #1946).

Do you think it solves the problem ?

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

closes #1946

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

Could you do a similar PR for QR-DQN in SB3 contrib?

@araffin araffin merged commit d8148de into DLR-RM:master Jul 5, 2024
4 checks passed
@corentinlger
Copy link
Contributor Author

Sure I'm gonna do that

friedeggs pushed a commit to friedeggs/stable-baselines3 that referenced this pull request Jul 22, 2024
…nput (DLR-RM#1963)

* Updated DQN optimizer input to only include q_network parameters

* Update version

---------

Co-authored-by: Antonin RAFFIN <antonin.raffin@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] DQN optimizer parameters
2 participants