Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect new dll loading policy of ctypes starting in Python 3.8 #843

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

joergbrech
Copy link
Contributor

Description

Fixes #842. Since ctypes changed it's dll loading policy in Python 3.8, we have to adapt our bindings generator.

How Has This Been Tested?

Tested with a local conda build in a Python 3.8 environment.

Screenshots, that help to understand the changes(if applicable):

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

@codecov-commenter
Copy link

Codecov Report

Merging #843 (5d35685) into master (3260a54) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
- Coverage   62.19%   62.16%   -0.03%     
==========================================
  Files         291      291              
  Lines       23494    24996    +1502     
==========================================
+ Hits        14611    15539     +928     
- Misses       8883     9457     +574     
Impacted Files Coverage Δ
src/common/Debugging.h 40.00% <0.00%> (-10.00%) ⬇️
src/rotor/CCPACSRotorBlades.cpp 65.38% <0.00%> (-5.45%) ⬇️
src/rotor/CCPACSRotorBladeAttachments.cpp 64.70% <0.00%> (-4.05%) ⬇️
src/wing/CCPACSWingSectionElement.cpp 17.39% <0.00%> (-3.67%) ⬇️
src/fuselage/CCPACSFuselageSectionElement.cpp 17.39% <0.00%> (-3.67%) ⬇️
src/rotor/CCPACSRotors.cpp 73.91% <0.00%> (-3.36%) ⬇️
src/CCPACSEtaXsiPoint.cpp 16.00% <0.00%> (-3.05%) ⬇️
src/CCPACSPositioning.cpp 65.88% <0.00%> (-3.04%) ⬇️
src/cpacs_other/CCPACSExternalObject.cpp 52.30% <0.00%> (-2.87%) ⬇️
src/CCPACSCurvePoint.cpp 11.76% <0.00%> (-2.53%) ⬇️
... and 209 more

@rainman110
Copy link
Collaborator

Great!

@rainman110 rainman110 merged commit e866b7b into master Oct 26, 2021
@joergbrech joergbrech deleted the 842-ctypes-dll-policy-py38 branch November 17, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda packages do not work on Python 3.8
3 participants