Fixed incorrect computation of wing aspect ratio #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
==========================================
+ Coverage 62.51% 62.58% +0.07%
==========================================
Files 291 292 +1
Lines 24527 24621 +94
==========================================
+ Hits 15332 15408 +76
- Misses 9195 9213 +18
|
rainman110
force-pushed
the
827_fix_wing_aspect_ratio
branch
from
7f26587 to
e0811e4
Compare
rainman110
force-pushed
the
827_fix_wing_aspect_ratio
branch
from
3df83f1 to
3f8831e
Compare
joergbrech
requested changes
Nov 11, 2021
|
This whole code in |
rainman110
force-pushed
the
827_fix_wing_aspect_ratio
branch
from
5872465 to
5be9f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The computation of the aspect ratio need to project the wing to a planform . The plane to be projected is typically the x-y plane. In cpacs however, users have the freedom to build the aircraft in another (rotated) way, so using the x-y plane is too restrictive.
The bug occured, because a wrong projection plane was selected. This led to a very small wing surface area and hence a large aspect ratio.
This code change fixes the issue by improving the selection of the projection plane. The code was back-ported from CPACS Creator, were the issue was already fixed before.
Closes #827
How Has This Been Tested?
A system test was added checking roughly the correct AR value.
Checklist: