Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Code for Ducts and adapt existing code base to it #887

Merged
merged 12 commits into from
Mar 21, 2022

Conversation

joergbrech
Copy link
Contributor

@joergbrech joergbrech commented Mar 16, 2022

Description

Fixes #888.

This is a preparation PR for #881. This PR includes the new ducts definition in the CPACS schema and the generated code. It adapts all relevent TiGL functions to it so that the code compiles and all unit and integration tests succeed.

The refactoring of the non-generated code boils down to making sure, that certain structural elements, as well as fuselage positionings, sections and segments do not automatically assume to be children of fuselages, since now they can belong to either a duct or a fuselage.

The actuall implementation of the ducts is not part of this PR. The CCPACSDuct::BuildLoft function exists but will error.

How Has This Been Tested?

All existing unit and integration tests are successfull.

Screenshots, that help to understand the changes(if applicable):

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

@joergbrech joergbrech marked this pull request as draft March 16, 2022 16:54
@joergbrech joergbrech force-pushed the 881-implement-ducts branch from fd50f99 to 8dc5bd6 Compare March 16, 2022 17:00
@joergbrech joergbrech marked this pull request as ready for review March 16, 2022 17:15
@codecov-commenter
Copy link

Codecov Report

Merging #887 (8551f55) into master (8b0a2ae) will decrease coverage by 0.18%.
The diff coverage is 51.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   62.53%   62.34%   -0.19%     
==========================================
  Files         292      296       +4     
  Lines       24640    24750     +110     
==========================================
+ Hits        15408    15430      +22     
- Misses       9232     9320      +88     
Impacted Files Coverage Δ
src/CCPACSPositionings.cpp 90.32% <0.00%> (-4.60%) ⬇️
src/ducts/CCPACSDuct.cpp 0.00% <0.00%> (ø)
src/ducts/CCPACSDuctStructure.cpp 0.00% <0.00%> (ø)
src/fuselage/CCPACSDoorAssemblyPosition.cpp 0.00% <0.00%> (ø)
src/fuselage/CCPACSFuselage.h 100.00% <ø> (ø)
src/fuselage/CCPACSFuselageSections.cpp 50.00% <0.00%> (-7.15%) ⬇️
src/fuselage/CCPACSFuselageSegment.h 50.00% <ø> (ø)
src/fuselage/CCPACSFuselageStringer.cpp 0.00% <0.00%> (ø)
...c/fuselage/CCPACSFuselageStringerFramePosition.cpp 4.06% <0.00%> (+0.06%) ⬆️
src/fuselage/CCPACSSkin.cpp 0.00% <0.00%> (ø)
... and 23 more

@joergbrech joergbrech merged commit 45fed0e into master Mar 21, 2022
@joergbrech joergbrech deleted the 881-implement-ducts branch March 21, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare TiGL for Ducts
3 participants