-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Code for Ducts and adapt existing code base to it #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joergbrech
force-pushed
the
881-implement-ducts
branch
from
March 16, 2022 17:00
fd50f99
to
8dc5bd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
- Coverage 62.53% 62.34% -0.19%
==========================================
Files 292 296 +4
Lines 24640 24750 +110
==========================================
+ Hits 15408 15430 +22
- Misses 9232 9320 +88
|
AntonReiswich
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #888.
This is a preparation PR for #881. This PR includes the new ducts definition in the CPACS schema and the generated code. It adapts all relevent TiGL functions to it so that the code compiles and all unit and integration tests succeed.
The refactoring of the non-generated code boils down to making sure, that certain structural elements, as well as fuselage positionings, sections and segments do not automatically assume to be children of fuselages, since now they can belong to either a duct or a fuselage.
The actuall implementation of the ducts is not part of this PR. The
CCPACSDuct::BuildLoft
function exists but will error.How Has This Been Tested?
All existing unit and integration tests are successfull.
Screenshots, that help to understand the changes(if applicable):
Checklist: