Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM 897 Export full fuselage and wing #898

Closed
wants to merge 32 commits into from
Closed

DNM 897 Export full fuselage and wing #898

wants to merge 32 commits into from

Conversation

joergbrech
Copy link
Contributor

Description

Fixes #897. Previously, the export added the fuselages and wings segmentwise.

How Has This Been Tested?

All unit and integration tests still work.

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

AntonReiswich and others added 30 commits March 21, 2022 17:09
@AntonReiswich
moved guide curve logic into CCPACSFuselageSegments
c9eb999
@AntonReiswich
implemented BuildLoft method for Ducts
25abbb4
@AntonReiswich
added GetDucts function
bb6444d
@AntonReiswich
added simple positioning tests
b7e10a7
@joergbrech
start implementing fuselage duct cutout
1b91ee8
@joergbrech
fuselage add switch for loft with or without ducts
6e6991d
@AntonReiswich
added some unittests for ducts
8b313e4
@joergbrech
move duct cutting logic to CCPACSDucts
d17f2de
@joergbrech
cut ducts from wing
7739b88
@joergbrech
small fix in WithDuct setters in wing and fuselage
8e2126e
@joergbrech
cutout ducts only from wingWithCutOuts, not flaps
2ea5876
@AntonReiswich
added two XML-files for duct testing
be774e1
@AntonReiswich
fixed bug in XML test file
cb46e49
@joergbrech
add CCPACSDuct(s) to internal python bindings
1355e5d
@AntonReiswich
fixed transformation issue in wing and fuselage for ducts
570d5db
@joergbrech
remove obsolete GetLoft function
3bb79f2
@joergbrech
add guide curves to Y duct
edef462
@joergbrech
small bugfix in guide curve tangent code
631b42a
@joergbrech
change INTENT for duct to PHYSICAL, so rel pos. works
d383ca6
@joergbrech
add parentUID and symmetry to Y duct
6c105ea
@joergbrech
add mirrored ducts to cutout tool
9c80124
@joergbrech
improve robustness of fused ducts
e41c11b
@joergbrech
fix Cache deadlock with ducts
96a8461
@joergbrech
reset loft and bb when changing withDucts flag
98e8037
@AntonReiswich
some more unittests
24dc331
@AntonReiswich
Merge branch '881-implement-ducts' of https://github.com/DLR-SC/tigl …
2d22a2e 
…into 881-implement-ducts
@joergbrech
rename WithDucts to WithDuctCutouts for less ambiguity
1c6c0c5
@joergbrech
Add API functions to set and get WithDuctCutouts flag
d67bfc9
@joergbrech
add option to draw configuration with duct cutouts
3180213
@joergbrech
fix minor issue in fusing of ducts
0f6c1a7
@joergbrech joergbrech requested a review from AntonReiswich April 4, 2022 12:47
@joergbrech joergbrech closed this Apr 4, 2022
@joergbrech
Copy link
Contributor Author

joergbrech commented Apr 4, 2022 •
edited
Loading

Sorry, today seems to be Monday...I meant to base this branch of master. I will open a new PR

@joergbrech joergbrech changed the title 897 Export full fuselage and wing DNM 897 Export full fuselage and wing Apr 4, 2022
@joergbrech joergbrech deleted the 897-export-full-fuselage-wing branch April 4, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonReiswich AntonReiswich Awaiting requested review from AntonReiswich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export of configuration should not export segmentwise
2 participants
@joergbrech @AntonReiswich