Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export fuselage and wings segmentwise. #899

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

joergbrech
Copy link
Contributor

Description

Fixes #897. See description in issue.

How Has This Been Tested?

existing unit and integration tests

Checklist:

  • A test for the new functionality was added.
  • All tests run without failure.
  • The new code complies with the TiGL style guide.
  • New classes have been added to the Python interface.
  • API changes were documented properly in tigl.h.

@joergbrech joergbrech requested a review from AntonReiswich April 4, 2022 15:36
@codecov-commenter
Copy link

Codecov Report

Merging #899 (5b0903a) into master (8127fbd) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   69.30%   69.28%   -0.02%     
==========================================
  Files         295      295              
  Lines       24748    24744       -4     
==========================================
- Hits        17151    17144       -7     
- Misses       7597     7600       +3     
Impacted Files Coverage Δ
src/exports/CTiglCADExporter.cpp 63.80% <50.00%> (-1.33%) ⬇️
src/geometry/CTiglTriangularizer.cpp 85.38% <0.00%> (-1.76%) ⬇️

@joergbrech joergbrech merged commit b0bc449 into master Apr 5, 2022
@joergbrech joergbrech deleted the 897-export-full-fuselage-wing branch April 5, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export of configuration should not export segmentwise
3 participants