This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Refactor ta_send_transfer_req_deserialization #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
suggested changes
Feb 15, 2019
jserv
reviewed
Feb 15, 2019
jserv
reviewed
Feb 15, 2019
wusyong
approved these changes
Feb 18, 2019
jserv
reviewed
Feb 18, 2019
serializer/serializer.c
Outdated
| void fill_tag(char* new_tag, char* old_tag, size_t tag_len) { | ||
| // fill in '9' | ||
| memset(new_tag, 57, NUM_TRYTES_TAG); | ||
| memcpy(new_tag, old_tag, tag_len); |
There was a problem hiding this comment.
Can you avoid duplicated memory operations?
There was a problem hiding this comment.
sprintf can deal this.
And what is the concern of duplicated memory operations? 🤔
jserv
reviewed
Feb 18, 2019
jserv
reviewed
Feb 19, 2019
jserv
reviewed
Feb 19, 2019
jserv
reviewed
Feb 19, 2019
jkrvivian
force-pushed
the
send_transfer_deserialization
branch
from
e1fe888
to
b964eef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #68