Skip to content

merging cleanup to main #140

merging cleanup to main

merging cleanup to main #140

Triggered via pull request November 22, 2024 11:42
Status Success
Total duration 7m 7s
Artifacts

check.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

34 warnings
Check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Check: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L158
variable does not need to be mutable
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L304
method `disconnect_pending_validators` is never used
Check: crates/ethcore/src/client/test_client.rs#L425
missing documentation for a method
Check
`ethcore` (lib) generated 5 warnings (run `cargo fix --lib -p ethcore` to apply 3 suggestions)
Check: bin/evmbin/src/main.rs#L339
field `cmd_stats` is never read
Check
`evmbin` (bin "openethereum-evm") generated 1 warning
Check
the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
Check: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L158
variable does not need to be mutable
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L304
method `disconnect_pending_validators` is never used
Check
`ethcore` (lib) generated 4 warnings (run `cargo fix --lib -p ethcore` to apply 3 suggestions)
Check: bin/oe/account_utils.rs#L19
unused import: `crypto::publickey`
Check: bin/oe/account_utils.rs#L21
unused import: `H160`
Check
`diamond-node` (lib) generated 2 warnings (run `cargo fix --lib -p diamond-node` to apply 2 suggestions)
Check
the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24
Check: crates/ethcore/src/engines/hbbft/keygen_transactions.rs#L158
variable does not need to be mutable
Check: crates/ethcore/src/engines/hbbft/hbbft_peers_management.rs#L304
method `disconnect_pending_validators` is never used
Check: crates/ethcore/src/client/test_client.rs#L425
missing documentation for a method
Check
`ethcore` (lib) generated 5 warnings (run `cargo fix --lib -p ethcore` to apply 3 suggestions)
Check: crates/db/memory-db/benches/bench.rs#L47
unnecessary trailing semicolon
Check
`memory-db` (bench "bench") generated 1 warning
Check: bin/evmbin/src/main.rs#L339
field `cmd_stats` is never read
Check
`evmbin` (bin "openethereum-evm" test) generated 1 warning
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/