Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I87 early epoch end improvements #129

Merged
merged 2 commits into from
Oct 22, 2024
Merged

I87 early epoch end improvements #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65cb273
improved logging for early epoch end reconnects
SurfingNerd Oct 21, 2024
14877c9
increased devp2p warmup time for not sending early epoch end reports …
SurfingNerd Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/ethcore/src/engines/hbbft/contracts/connectivity_tracker_hbbft.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ pub fn report_reconnect(
.gas(U256::from(200_000))
.nonce(nonce);

info!(target:"consensus", "early-epoch-end: sending report_missing_connectivity for with nonce: {nonce}, missing: {:?} ", reconnected_validator);
info!(target:"engine", "early-epoch-end: sending report_reconnect for with nonce: {nonce}, missing: {:?} ", reconnected_validator);
if let Err(e) = full_client.transact_silently(transaction) {
warn!(target:"consensus", "early-epoch-end: could not report_missing_connectivity {e:?}");
warn!(target:"engine", "early-epoch-end: could not report_missing_connectivity {e:?}");
return false;
}
return true;
Expand Down
2 changes: 1 addition & 1 deletion crates/ethcore/src/engines/hbbft/hbbft_engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,7 @@
mining_address: &Address,
) {
// todo: acquire allowed devp2p warmup time from contracts ?!
let allowed_devp2p_warmup_time = Duration::from_secs(120);
let allowed_devp2p_warmup_time = Duration::from_secs(1200);

debug!(target: "engine", "early-epoch-end: handle_early_epoch_end.");

Expand Down Expand Up @@ -1175,7 +1175,7 @@
Err(e) => {
error!(target: "consensus", "Error initializing synckeygen: {:?}", e);
}
Err(_) => {

Check warning on line 1178 in crates/ethcore/src/engines/hbbft/hbbft_engine.rs

View workflow job for this annotation

GitHub Actions / Test and Build (ubuntu-latest, 1.72) 

unreachable pattern

Check warning on line 1178 in crates/ethcore/src/engines/hbbft/hbbft_engine.rs

View workflow job for this annotation

GitHub Actions / Test and Build (ubuntu-latest, 1.72) 

unreachable pattern

Check warning on line 1178 in crates/ethcore/src/engines/hbbft/hbbft_engine.rs

View workflow job for this annotation

GitHub Actions / Check 

unreachable pattern

Check warning on line 1178 in crates/ethcore/src/engines/hbbft/hbbft_engine.rs

View workflow job for this annotation

GitHub Actions / Check 

unreachable pattern

Check warning on line 1178 in crates/ethcore/src/engines/hbbft/hbbft_engine.rs

View workflow job for this annotation

GitHub Actions / Check 

unreachable pattern
error!(target: "consensus", "Error initializing synckeygen: unknown Error");
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/ethcore/src/engines/hbbft/hbbft_state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ impl HbbftState {
warn!(target: "engine", "could not acquire to connect to current validators on switching to new validator set for staking epoch {}.", self.current_posdao_epoch);
}

let allowed_devp2p_warmup_time = Duration::from_secs(120);
let allowed_devp2p_warmup_time = Duration::from_secs(1200);

if let Some(full_client) = client.as_full_client() {
let signing_address = if let Some(s) = signer.read().as_ref() {
Expand Down
Loading