Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where get_supported_problems_and_mtimes won't recursively scan #1104

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

kiritofeng
Copy link
Member

Also added a test.

Additional question: should we return a problem multiple times if it has different locations?

@kiritofeng kiritofeng requested a review from Xyene January 29, 2023 03:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Base: 81.66% // Head: 84.50% // Increases project coverage by +2.83% 🎉

Coverage data is based on head (26da9de) compared to base (d96b12b).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
+ Coverage   81.66%   84.50%   +2.83%     
==========================================
  Files         139      139              
  Lines        4995     5000       +5     
==========================================
+ Hits         4079     4225     +146     
+ Misses        916      775     -141     
Impacted Files Coverage Δ
dmoj/judgeenv.py 68.06% <100.00%> (+5.04%) ⬆️
dmoj/tests/test_globs.py 100.00% <100.00%> (ø)
dmoj/judge.py 54.54% <0.00%> (+1.21%) ⬆️
dmoj/executors/java_executor.py 85.35% <0.00%> (+2.02%) ⬆️
dmoj/cptbox/compiler_isolate.py 55.31% <0.00%> (+6.38%) ⬆️
dmoj/cptbox/tracer.py 76.32% <0.00%> (+15.90%) ⬆️
dmoj/cptbox/handlers.py 100.00% <0.00%> (+26.31%) ⬆️
dmoj/cptbox/isolate.py 89.63% <0.00%> (+38.41%) ⬆️
dmoj/control.py 100.00% <0.00%> (+64.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xyene
Copy link
Member

Xyene commented Jan 29, 2023

Additional question: should we return a problem multiple times if it has different locations?

No, we should return the first one, and maybe print a warning about the second, but not return it.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 3180c23 into master Jan 29, 2023
@Xyene Xyene deleted the globsob branch January 29, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants