Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO: allow package main;; closes #544 #582

Merged
merged 1 commit into from
Nov 11, 2019
Merged

GO: allow package main;; closes #544 #582

merged 1 commit into from
Nov 11, 2019

Conversation

kiritofeng
Copy link
Member

No description provided.

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could possibly cause the whole file to be replaced?

@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #582 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   87.23%   87.24%   +<.01%     
==========================================
  Files          93       93              
  Lines        2100     2101       +1     
==========================================
+ Hits         1832     1833       +1     
  Misses        268      268
Impacted Files Coverage Δ
dmoj/executors/GO.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9791337...82f0a37. Read the comment docs.

@kiritofeng kiritofeng force-pushed the go-package-main branch 3 times, most recently from b665866 to 65830bb Compare November 9, 2019 20:35
@kiritofeng kiritofeng requested a review from quantum5 November 9, 2019 20:35
dmoj/executors/GO.py Outdated Show resolved Hide resolved
Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough, can't be less broken than before.

@kiritofeng kiritofeng merged commit 8d7c4a6 into master Nov 11, 2019
@kiritofeng kiritofeng deleted the go-package-main branch November 11, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants