Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metaclass to auto-populate Executor.name #969

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Conversation

quantum5
Copy link
Member

@quantum5 quantum5 commented Dec 6, 2021

No description provided.

@quantum5 quantum5 requested a review from Xyene December 6, 2021 01:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #969 (60de54b) into master (2871cb3) will decrease coverage by 5.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage   86.55%   80.56%   -5.99%     
==========================================
  Files         138      138              
  Lines        4737     4673      -64     
==========================================
- Hits         4100     3765     -335     
- Misses        637      908     +271     
Impacted Files Coverage Δ
dmoj/executors/ADA.py 100.00% <ø> (ø)
dmoj/executors/AWK.py 100.00% <ø> (ø)
dmoj/executors/BASH.py 0.00% <ø> (ø)
dmoj/executors/BF.py 94.11% <ø> (-0.17%) ⬇️
dmoj/executors/C.py 100.00% <ø> (ø)
dmoj/executors/C11.py 100.00% <ø> (ø)
dmoj/executors/CBL.py 95.00% <ø> (-0.24%) ⬇️
dmoj/executors/CLANG.py 100.00% <ø> (ø)
dmoj/executors/CLANGX.py 100.00% <ø> (ø)
dmoj/executors/COFFEE.py 88.00% <ø> (-0.47%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2871cb3...60de54b. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quantum5 quantum5 merged commit 9315a8e into master Dec 6, 2021
@quantum5 quantum5 deleted the executor-auto-name branch December 6, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants