Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cptbox: allow statx by default #978

Merged
merged 1 commit into from
Jan 1, 2022
Merged

cptbox: allow statx by default #978

merged 1 commit into from
Jan 1, 2022

Conversation

quantum5
Copy link
Member

It used to only be allowed for compilers, but there is no reason why
it should be compiler-only given that other stat syscalls are allowed
for everything.

This will fix the failure with Turing on latest glibc.

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #978 (bcc8a59) into master (f453014) will increase coverage by 2.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   80.80%   83.74%   +2.93%     
==========================================
  Files         138      138              
  Lines        4695     4695              
==========================================
+ Hits         3794     3932     +138     
+ Misses        901      763     -138     
Impacted Files Coverage Δ
dmoj/cptbox/isolate.py 86.55% <ø> (+47.05%) ⬆️
dmoj/executors/compiled_executor.py 77.71% <ø> (+4.00%) ⬆️
dmoj/judge.py 52.83% <0.00%> (+1.25%) ⬆️
dmoj/executors/java_executor.py 85.35% <0.00%> (+2.02%) ⬆️
dmoj/cptbox/tracer.py 77.33% <0.00%> (+18.34%) ⬆️
dmoj/cptbox/handlers.py 100.00% <0.00%> (+25.00%) ⬆️
dmoj/control.py 100.00% <0.00%> (+64.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f453014...bcc8a59. Read the comment docs.

It used to only be allowed for compilers, but there is no reason why
it should be compiler-only given that other stat syscalls are allowed
for everything.

This will fix the failure with Turing on latest glibc.
@quantum5 quantum5 changed the title cptbox: all statx by default cptbox: allow statx by default Dec 31, 2021
@quantum5 quantum5 merged commit 8877809 into master Jan 1, 2022
@quantum5 quantum5 deleted the statx branch January 1, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants