Fix race condition between freeing judge and judge selection (#1468)

DMOJ · Jun 21, 2020 · 139dbb6 · 139dbb6
1 parent f06d796
commit 139dbb6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/judge/bridge/judge_handler.py b/judge/bridge/judge_handler.py
@@ -581,7 +581,6 @@ def on_ping_response(self, packet):
         self._update_ping()
 
     def _free_self(self, packet):
-        self._working = False
         self.judges.on_judge_free(self, packet['submission-id'])
 
     def _ping_thread(self):

diff --git a/judge/bridge/judge_list.py b/judge/bridge/judge_list.py
@@ -78,6 +78,7 @@ def on_judge_free(self, judge, submission):
         with self.lock:
             logger.info('Judge available after grading %d: %s', submission, judge.name)
             del self.submission_map[submission]
+            judge._working = False
             self._handle_free_judge(judge)
 
     def abort(self, submission):