Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode online judge #2035

Open
4 of 7 tasks
int-y1 opened this issue Nov 13, 2022 · 13 comments
Open
4 of 7 tasks

Dark mode online judge #2035

int-y1 opened this issue Nov 13, 2022 · 13 comments

Comments

@int-y1
Copy link
Contributor

int-y1 commented Nov 13, 2022

This is for the many users who requested dark mode. This issue is possibly a subset of #578.

A few general guidelines:

  • I will try to keep this description up to date. For any bugs that I missed, feel free to post them in this issue.
  • Feel free to make a PR for any of these bugs. A few tips to make review easier:
    • If you're working with SCSS, you'll find these files useful: /resources/vars-*.scss
    • You can put Part of #2035 in your PR description. Don't put Closes #2035/Fixes #2035.
    • Post a screenshot of before change + after change.
    • For small changes, average review time is ~2 days. For big changes, review will take longer.

Important styling bugs:

Less important styling bugs:

When you're bored:

  • Go to /edit/profile/, enable experimental features, and set site theme to dark. Visit any page, and try to find styling bugs.
  • Find page-specific <style> with git grep -n "<style". At a minimum, migrate the color-specific properties into scss file(s).
  • Import more ace.js themes from upstream (see @Xyene's comment).
@int-y1

This comment was marked as outdated.

@Xyene

This comment was marked as outdated.

@Xyene

This comment was marked as outdated.

@jdabtieu

This comment was marked as outdated.

@Xyene

This comment was marked as outdated.

@Xyene

This comment was marked as outdated.

@Xyene

This comment was marked as resolved.

@Xyene
Copy link
Member

Xyene commented Feb 6, 2023

image

instead of

image

Headers should be brighter than the content they are heading.

@Riolku

This comment was marked as resolved.

@jdabtieu

This comment was marked as resolved.

@kiritofeng

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants