Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move constants to settings.py #993

Closed
kiritofeng opened this issue May 4, 2019 · 0 comments · Fixed by #1107
Closed

Move constants to settings.py #993

kiritofeng opened this issue May 4, 2019 · 0 comments · Fixed by #1107
Assignees
@Carson-Tang
Labels
cleanup easy
Milestone
2.0.0

Comments

@kiritofeng
Copy link
Member

Currently constants are accessed as getattr(settings, SETTING_NAME, SETTING_DEFAULT).

This leads to a lot of hardcoding of SETTING_DEFAULT, as well as unnecessarily long code that could be avoided if these constants and their default values were instead added to settings.py.
@kiritofeng kiritofeng added the easy label May 4, 2019
@Xyene Xyene added this to the 1.5.0 milestone Sep 29, 2019
@Carson-Tang Carson-Tang mentioned this issue Sep 30, 2019
Closed
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 4, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
65e8546
@Carson-Tang Carson-Tang mentioned this issue Oct 4, 2019
Merged
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 4, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
d61fe39
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 4, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
bb48981
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 5, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
ff75637
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 5, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
2280b3b
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 5, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
4280ea0
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 5, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
5e72f54
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 10, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
7eb13ee
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 13, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
0809e3a
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 14, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
ce4ba9d
Carson-Tang added a commit to Carson-Tang/site that referenced this issue Oct 14, 2019
@Carson-Tang
Moves constants to 'settings.py'; DMOJ#993
a346661
Xyene pushed a commit that referenced this issue Oct 20, 2019
@Carson-Tang @Xyene
Moves constants to 'settings.py'; #993
f479d87
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
@Carson-Tang @Xyene
Moves constants to 'settings.py'; DMOJ#993
7d8db5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Carson-Tang Carson-Tang

Labels
cleanup easy
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Moves constants to 'settings.py'; #993 Carson-Tang/site
Moves constants to settings.py; #993
4 participants
@quantum5 @Xyene @kiritofeng @Carson-Tang