Make Problem.is_accessible_by consistent with Problem.get_visible_problems
#1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 37.92% 37.92%
=======================================
Files 198 198
Lines 11339 11339
=======================================
Hits 4300 4300
Misses 7039 7039
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
is_accessible_bycheck doesn't take into account users who haveedit_public_problemoredit_all_problem, or author/curator fields when the user does not have theedit_own_problempermission, whileget_visible_problemsdo. This causes some problems to show up, but when a user clicks on the link, it will lead to a 404 page.This PR is required to allow the unittests in #1416 to pass (correctly).