Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally deny access when a comment's related object doesn't exist #1426

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

Ninjaclasher
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1426 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
- Coverage   37.92%   37.91%   -0.02%     
==========================================
  Files         198      198              
  Lines       11337    11340       +3     
==========================================
  Hits         4300     4300              
- Misses       7037     7040       +3     
Impacted Files Coverage Δ
judge/models/comment.py 38.81% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e7a38...6ed0f4d. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@Xyene Xyene merged commit 31215fe into DMOJ:master Jun 4, 2020
@Ninjaclasher Ninjaclasher deleted the comment-check branch June 5, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants