Exempt flatpages from the HTML restrictions #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As bleach is only activated for flatpages that use the `markdown.html` and `markdown_math.html` templates, a staff could bypass the HTML restrictions by simply using another template (e.g `default.html`). Changing template names does not require any additional permissions.
Codecov Report
@@ Coverage Diff @@
## master #1431 +/- ##
=======================================
Coverage 38.44% 38.44%
=======================================
Files 201 201
Lines 11398 11398
=======================================
Hits 4382 4382
Misses 7016 7016
Continue to review full report at Codecov.
|
Xyene
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As bleach is only activated for flatpages that use the
markdown.htmlandmarkdown_math.htmltemplates, a staff could bypass the HTML restrictions by simply using another template (e.gdefault.html). Changing template names does not require any additional permissions.I think someone who creates a flatpage would expect full HTML access by default, so disallowing full HTML access for all the flatpage templates doesn't seem like the correct move (of course, I could be wrong). If required, this PR could be modified to disallow full HTML access for all the templates.