Use has_other_pages() to check if the pagination bar should be shown
#1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
=======================================
Coverage 38.42% 38.42%
=======================================
Files 201 201
Lines 11410 11410
=======================================
Hits 4384 4384
Misses 7026 7026 Continue to review full report at Codecov.
|
...rather than the number of pages since the infinite paginator returns a constant 1e3000 even if there is only 1 page.
Ninjaclasher
force-pushed
the
pagination-bar
branch
from
9376f30 to
a9278e2
Compare
Ninjaclasher
changed the title
has_other_pages() to check if the pagination bar should be shown.has_other_pages() to check if the pagination bar should be shown
quantum5
approved these changes
Jun 12, 2020
|
I mean, the infinite paginator probably shouldn't return infinity if it knows the number of pages, but this change will make it look more elegant than |
outloudvi
pushed a commit
to SchOJ/site
that referenced
this pull request
Oct 27, 2020
DMOJ#1446) ...rather than the number of pages since the infinite paginator returns a constant 1e3000 even if there is only 1 page.
malbareda
pushed a commit
to malbareda/JOEL-web
that referenced
this pull request
Jan 4, 2024
DMOJ#1446) ...rather than the number of pages since the infinite paginator returns a constant 1e3000 even if there is only 1 page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...Rather than the number of pages since the infinite paginator
returns a constant 1e3000 even if there is only 1 page.