Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (slightly better) mobile support for comments #1455

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

Ninjaclasher
Copy link
Member

In particular:

  • Less indenting for small-width screens
  • Decreased gravatar width for small-width screens
  • Use flexbox instead of float:right; to make the admin controls display nicer.

Everything should look exactly the same on a computer screen.

Before:
image

After:
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #1455 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files         207      207           
  Lines       11885    11885           
=======================================
  Hits         5420     5420           
  Misses       6465     6465           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d2ceb...6881652. Read the comment docs.

@kiritofeng
Copy link
Member

I personally am not a fan of the empty space directly below the icon, what if we moved the icon directly beside the username?

@Ninjaclasher
Copy link
Member Author

Something like this?
image

@Ninjaclasher
Copy link
Member Author

Implemented ^. I'm not sure if there is a better way to do this without having two gravatars (and choosing which one to make visible).

New after:
image

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene merged commit 494bde6 into DMOJ:master Jun 19, 2020
@Ninjaclasher Ninjaclasher deleted the comment-mobile branch June 21, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants