Skip to content

Commit

Permalink
MInor fix
Browse files Browse the repository at this point in the history
  • Loading branch information
patrick-dmxc committed May 10, 2024
1 parent 9cea558 commit dd937c3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion ArtNetSharp/Communication/AbstractInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,11 @@ private async Task sendArtPollReply(IPv4Address ownIp, IPv4Address destinationIp
try
{
await Task.Delay((int)(800 * _random.NextDouble())); //Art-Net 4 Protocol Release V1.4 Document Revision 1.4dh 19/7/2023 - 23 -
MACAddress ownMacAddress = ArtNetInstance.GetMacAdress(ownIp);

if (this.IsDisposing || this.IsDisposed || this.IsDeactivated)
return;

MACAddress ownMacAddress = ArtNetInstance?.GetMacAdress(ownIp);

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 8.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 7.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)

Check failure on line 385 in ArtNetSharp/Communication/AbstractInstance.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest, 6.0)

Cannot implicitly convert type 'RDMSharp.MACAddress?' to 'RDMSharp.MACAddress'. An explicit conversion exists (are you missing a cast?)
NodeStatus nodeStatus = getOwnNodeStatus();
NodeReport nodeReport = new NodeReport(ENodeReportCodes.RcPowerOk, "Everything ok.", artPollReplyCounter);
Net net = 0;
Expand Down
2 changes: 1 addition & 1 deletion ArtNetTests/LoggingTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace ArtNetTests.Logging
{
public class LoggingTests
{
[Test]
[Test, Order(-1)]
public void TestLogging()
{
var logger = NullLoggerFactory.Instance.CreateLogger(nameof(LoggingTests));
Expand Down

0 comments on commit dd937c3

Please sign in to comment.