Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation-OAUTH-M365-tutorial #733

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

aspelt
Copy link
Contributor

@aspelt aspelt commented Feb 10, 2025

Creation of a page where the tutorial will come

@valadas
Copy link
Member

valadas commented Feb 10, 2025

This appears to be the same as #732

@aspelt if you need any help figuring out branching, we do co-coding sessions on discord almost every Friday. Discord link is on the community website home page and then you'll see the co-coding sessions in the Events over at Discord. Happy to help and excited to see this feature being documented!

@aspelt
Copy link
Contributor Author

aspelt commented Feb 10, 2025

Sorry, I made a mistake. I created a branche but the page with the version history was double posted. Myt intention is to write documentation for the implementation of OAUTH in DNNDOCS. In this pullrequest I created a page. I didn't fill the page yet, because it is my first page in DNNDOCS. When the page is approved I will fill it with the documentation.

@valadas
Copy link
Member

valadas commented Feb 10, 2025

Any reason for creating an empty page in one step and then adding the documentation later ?

@aspelt
Copy link
Contributor Author

aspelt commented Feb 10, 2025

Yes, it is my first page in dnndocs. I will check that I did the right thing at the right place. After that I will filll the page. (still reading the docfx documentation)

Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind too much having the history update and a blank page here but only if we actually have documentation about the O365 setup or we kinda look bad having a blank page for something nobody knows how to setup. @aspelt you do know how to setup it up right and will submit those docs soon?


## Placeholder

This is a new page. Tutorial wil follow soon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is a new page. Tutorial wil follow soon
This is a new page. Tutorial will follow soon

@aspelt
Copy link
Contributor Author

aspelt commented Feb 16, 2025

I will describe all the steps for a succesfull implementatiion. It works in my own M365 tennants and I have had a verification session with Stefan Kamphuis.

@valadas
Copy link
Member

valadas commented Feb 16, 2025

@aspelt Awesome, I'll merge this if it makes it easier for you. Looking forward to finally see this getting documented!!!

@valadas valadas merged commit b7ff42b into DNNCommunity:main Feb 16, 2025
3 checks passed
@aspelt aspelt deleted the Implementation-OAUTH-M365-tutorial branch February 16, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants