Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to avoid resource recreation #8

Merged
merged 1 commit into from
May 2, 2022

Conversation

adenot
Copy link
Member

@adenot adenot commented May 2, 2022

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@adenot
Copy link
Member Author

adenot commented May 2, 2022

Related to hashicorp/terraform-provider-aws#22595

@adenot adenot requested a review from lzrocha May 2, 2022 00:50
@mvsnogueira-dnx mvsnogueira-dnx self-requested a review May 2, 2022 00:59
@adenot adenot merged commit 6d4de05 into master May 2, 2022
@adenot adenot deleted the bugfix/ignore-condition branch May 2, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants