Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: app's ssm parameters creation #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature: app's ssm parameters creation #34

wants to merge 1 commit into from

Conversation

rbbrasil
Copy link
Contributor

This PR adds a feature to create app's SSM parameters within the ECS cluster's service creation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@jrpradojr jrpradojr requested a review from adenot May 17, 2022 14:14
adenot
adenot reviewed May 19, 2022
View reviewed changes
ssm.tf
value = each.value

lifecycle {
ignore_changes = [value]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably don't need ignore_changes here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adenot adenot adenot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbbrasil @adenot