Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated lronacal to compute sun to body distance from cached ephem data #3611

Merged
merged 4 commits into from
Dec 20, 2019

Conversation

Kelvinrr
Copy link
Collaborator

@Kelvinrr Kelvinrr commented Dec 18, 2019

Description

Added Spice:: sunToBodyDist() to get sun to body distance from sunPosition and bodyRotation. lronaccal attempts to use the camera model for computation else defaults to old implementation.

Related Issue

#1790

Motivation and Context

How Has This Been Tested?

Manually verified results. Need to write gtests for new sun-body distance function.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@Kelvinrr Kelvinrr requested a review from scsides December 18, 2019 20:59
krlberry
krlberry previously approved these changes Dec 20, 2019
Copy link
Contributor

@krlberry krlberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, just one documentation thing and a debug statement left in.

isis/src/base/objs/Spice/Spice.cpp Show resolved Hide resolved
isis/src/base/objs/Spice/Spice.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@scsides scsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants