Update hyb2onc2isis to support newer image format #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlberry
requested review from
acpaquette,
jessemapel,
scsides,
Kelvinrr,
kaitlyndlee and
AustinSanders
|
The jenkins failure: 1200 - |
jessemapel
reviewed
Mar 30, 2020
| >& /dev/null; | ||
| catoriglab from=$(OUTPUT)/hyb2_onc_20180710_060508_tvf_l2a.cub \ | ||
| to=$(OUTPUT)/origLab.pvl \ | ||
| >& /dev/null; |
There was a problem hiding this comment.
Is the test data for this already checked in?
There was a problem hiding this comment.
For new tests, it's okay to check in the test data early as it won't conflict with other PRs or dev.
There was a problem hiding this comment.
Forgot about that, good point.
jessemapel
approved these changes
Mar 30, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
hyb2onc2isisto support more a recent format of Hayabusa2 fits images with different label keywords needed by ISIS. Most of this PR is just adding the changes to translation files identified by @foobarbecue (Thanks!) in #3698 to ISIS.To get the resulting cubes spiceinit-ing, it was also necessary to make several updates to the hayabusa2 kernel area.
Related Issue
#3698
Motivation and Context
Updates
hyb2onc2isisto work with more recently released Hayabusa2 fits files.The label format has changed enough that the translation files needed to be updated.How Has This Been Tested?
Old hayabusa2 tests pass and added a test for the new format.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: