Changed how Histogram separates data into bins #3917
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of PR #3914. Credit to @kaitlyndlee for the majority of content in this PR.
The math for calculating what bin data should be placed in and how
Histogram
calculated the min/max values of each bin seemed off. The math changed slightly to be more intuitive. In addition, the output of hist and cnethist changed to display the min/max values of each bin instead of the middle pixel's DN.Related Issue
#3882
Motivation and Context
Makes hist and cnethist behave in the way users expect them to.
How Has This Been Tested?
All existing app tests passed with the exception of hist_app_test_default. Truth data was updated, is passing locally, and is ready for checkin.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: